Use PCRE2 instead of PCRE #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PCRE is now at end of life, and is no longer being actively maintained. Lift the required version to the major version PCRE2. Removed the pcre study option since: "The new API ... was simplified by abolishing the separate "study" optimizing function; in PCRE2, patterns are automatically optimized where possible."
c9s
approved these changes
Oct 14, 2023
If asprintf() fails the content of the 'strp' variable is undefined. Lets check the return value and return NULL upon error. https://man7.org/linux/man-pages/man3/asprintf.3.html
Pattern and subject can straighforwardly be cast to PCRE2_SPTR since we only work with 8-bit code units.
|
As a reference here are some benchmark tests of Results from benchmarking of "pcre_dispatch"
Results taken from: gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 |
|
wow! this is just too awesome! |
c9s
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCRE is now at end of life and is no longer actively maintained.
This PR lifts the required version to the maintained PCRE2, which makes sure that security vulnerability fixes are available.
There are some differences in behaviour that is expressed in this list, but in general PCRE2 seems to have a more explicit pattern interpreter, so invalid patterns are checked more aggressively.
There are no need to change existing testcases which is a good sign.
This PR also removes the PCRE study option since:
The new API ... was simplified by abolishing the separate "study" optimizing function; in PCRE2, patterns are automatically optimized where possible.(link)Fixes #112