Fix compiler warnings #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building using a newer Clang with additional diagnostics the following warnings are given: -Wunused-but-set-variable -Wstrict-prototypes These issues are corrected in this commit. Reproducable using: CC="clang-13" CFLAGS="-Wall -pedantic" cmake ..
Fixes [-Wformat-extra-args] warnings when built using GCC, See details in: libcheck/check#298
c9s
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang warnings:
When building using a newer Clang with additional diagnostics the following warnings are indicated:
This is corrected by removing the unused variable and adding
voidto function definitions/declarations.Reproducible using
CC="clang-13" CFLAGS="-Wall -pedantic" cmake ..GCC warnings:
When building with gcc >= 11 the following warning is indicated:
This is corrected by replacing the use of the deprecated libcheck API
fail_if()withck_assert_msgaccording to recommendation.This warning can be seen in a CI run.