Skip to content

Commit

Permalink
Make tests fail the build. Conduct exit status of tests correctly
Browse files Browse the repository at this point in the history
  • Loading branch information
forus committed May 1, 2024
1 parent e09e1e2 commit 7b527b6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/validate-python.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: 'Validate tests'
working-directory: ./cbioportal-core
run: |
docker run -v ${PWD}:/cbioportal-core python:3.6 /bin/bash -c '
docker run -v ${PWD}:/cbioportal-core python:3.6 /bin/sh -c '
cd cbioportal-core &&
pip install -r requirements.txt &&
source test_scripts.sh'
./test_scripts.sh'
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ After you are done with the setup, you can build and test the project.

1. Execute tests through the provided script:
```bash
source test_scripts.sh
./test_scripts.sh
```

2. Build the loader jar using Maven (includes testing):
Expand Down
4 changes: 3 additions & 1 deletion test_scripts.sh
100644 → 100755
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
pushd tests/; PYTHONPATH=../scripts:$PYTHONPATH python -m unittest *.py; popd
#!/bin/bash

pushd tests/ && PYTHONPATH=../scripts:$PYTHONPATH python -m unittest *.py; exit_stat=$?; popd; exit $exit_stat

0 comments on commit 7b527b6

Please sign in to comment.