Optimize CnaEvent lookup and storage in CnaUtil #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the performance of the storeCnaEvents method by replacing the stream-based lookup with a HashSet contains check. This change reduces the computational complexity from O(n) to O(1) for the lookup operation, resulting in a significant performance gain when processing large collections of CnaEvent objects.
sgicbpc
force-pushed
the
cna_util_store_cna_events_performance_improvement
branch
from
a2e02d1
to
9ce5721
Compare
|
Hi, |
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the performance of the storeCnaEvents method by replacing the stream-based lookup with a HashSet contains check. This change reduces the computational complexity from O(n) to O(1) for the lookup operation, resulting in a significant performance gain when processing large collections of CnaEvent objects.
Note: This PR is carried over from cBioPortal/cbioportal#10478
Requesting review and merge from @JREastonMarks . Thank you!