Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group comparison download #3783

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

dippindots
Copy link
Member

@dippindots dippindots commented Jun 4, 2021

Fix cBioPortal/cbioportal#8485

logRatio can be undefined, return - when it's undefined.

  • logRatio Undefined case
    image

Testing:

  1. Go to https://genie.cbioportal.org/comparison/alterations?sessionId=60664081e4b0242bd5d46323
  2. Set localStorage.netlify ="deploy-preview-3783--cbioportalfrontend" in browser console.
  3. Click download button
    image

@@ -612,7 +612,7 @@ export function getAlterationEnrichmentColumns(
),
sortBy: (d: AlterationEnrichmentRow) => Number(d.logRatio),
download: (d: AlterationEnrichmentRow) =>
formatLogOddsRatio(d.logRatio!),
d.logRatio ? formatLogOddsRatio(d.logRatio) : '-',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dippindots is the "-" what we use elsewhere for empty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisman alisman merged commit 1d8120e into cBioPortal:master Jun 9, 2021
@dippindots dippindots deleted the fix-8485 branch June 9, 2021 22:04
@inodb inodb added the bug label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group comparison: Download button is not working for GENIE portals
3 participants