Add discrete_long cna data type #4423
Conversation
| @@ -2694,7 +2695,7 @@ export class ResultsViewPageStore | |||
| profile => | |||
| profile.molecularAlterationType === | |||
| AlterationTypeConstants.COPY_NUMBER_ALTERATION && | |||
| profile.datatype === DataTypeConstants.DISCRETE | |||
| CnaDataTypes.includes(profile.datatype) | |||
There was a problem hiding this comment.
Do we need this? Or maybe just keep
profile.molecularAlterationType === AlterationTypeConstants.COPY_NUMBER_ALTERATION
is enough?
| @@ -510,7 +514,7 @@ export function pickCopyNumberEnrichmentProfiles(profiles: MolecularProfile[]) { | |||
| (profile: MolecularProfile) => | |||
| profile.molecularAlterationType === | |||
| AlterationTypeConstants.COPY_NUMBER_ALTERATION && | |||
| profile.datatype === 'DISCRETE' | |||
| CnaDataTypes.includes(profile.datatype) | |||
Thanks for reviewing @dippindots! On second thought, maybe this whole new Any thoughts? |
|
@BasLee @pvannierop as far as I can tell, there is no special treatment given to DISCRETE_LONG datatype in the frontend. If that's true, and will always be true, perhaps we should make an effort to hide it from the frontend? Apologies if I misunderstand. |
|
Ok, we can shelve/delete this PR, in favor of the changes mentioned in cBioPortal/cbioportal#9847 (comment) |
|
We have decided to hide this new type (which is only relevant to import process) |
Add
DISCRETE_LONGas a possible CNA data type.Fixes e2e test failures introduced by the new CNA long format of cBioPortal/cbioportal#9847
Changes
DISCRETE_LONGto data typesCnaDataTypesthat contains both possible cna data types