Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mutations table and fisher exact two-sided p value to comparison lollipop #4556

Merged
merged 21 commits into from
Jul 7, 2023
Merged

Add mutations table and fisher exact two-sided p value to comparison lollipop #4556

merged 21 commits into from
Jul 7, 2023

Commits on Jul 7, 2023

  1. add mutations table and fisher exact p value

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    d53b397 View commit details
    Browse the repository at this point in the history

  2. fix pvge mutation table count header and adjust badge selector height

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    46ba254 View commit details
    Browse the repository at this point in the history

  3. added co-occurrence patern, p value, q value, enriched in columns and… 

    … dropdown, shift click message. specified fisher test use in text
    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a25829e View commit details
    Browse the repository at this point in the history

  4. fix mutations not filtering by selected transcript

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    731c33a View commit details
    Browse the repository at this point in the history

  5. fix transcript and text bugs, add significant only checkbox, fisher l… 

    …abel displays numbers used, changes to layout
    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2a2dce3 View commit details
    Browse the repository at this point in the history

  6. use merge mutations to set table data

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    e52ac30 View commit details
    Browse the repository at this point in the history

  7. addressed comments and feedback from review

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    18a8e13 View commit details
    Browse the repository at this point in the history

  8. refactoring and addressing comments from second review

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    14bd909 View commit details
    Browse the repository at this point in the history

  9. fix fisher label, results view lollipop tooltip and y axis label, com… 

    …parison filter alert and table
    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    2f254ec View commit details
    Browse the repository at this point in the history

  10. fix typo in alteration overlap

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    42f7ac3 View commit details
    Browse the repository at this point in the history

  11. fix reset filter bug

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    87e6df4 View commit details
    Browse the repository at this point in the history

  12. fix oncokb annotation actionability handling, overlap tooltip text an… 

    …d table header styling
    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    83c8f69 View commit details
    Browse the repository at this point in the history

  13. change fisher test to use two-sided throughout

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    7c11e8f View commit details
    Browse the repository at this point in the history

  14. change tests to use two-sided fisher test

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f9cd5e3 View commit details
    Browse the repository at this point in the history

  15. fix patient view mutation table annotations not loading

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1928a93 View commit details
    Browse the repository at this point in the history

  16. update screenshots

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    4238602 View commit details
    Browse the repository at this point in the history

  17. sort by p-value

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    65baff2 View commit details
    Browse the repository at this point in the history

  18. remove numbers from fisher label

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    0e6926d View commit details
    Browse the repository at this point in the history

  19. address review comments

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    de2bf9c View commit details
    Browse the repository at this point in the history

  20. add column formatter and fisher two sided unit tests

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    73cd7bc View commit details
    Browse the repository at this point in the history

  21. add e2e and screenshot tests for comparison mutations table

    Bryan Lai committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    24bf9a8 View commit details
    Browse the repository at this point in the history