Fix Sift and Polyphen blank in NRAS #5039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
leexgh
force-pushed
the
fix-sift-polyphen
branch
from
eb00ee3
to
8fcef5f
Compare
leexgh
force-pushed
the
fix-sift-polyphen
branch
from
8fcef5f
to
77a500e
Compare
onursumer
approved these changes
Nov 6, 2024
| @@ -25,6 +25,7 @@ import GenomeNexusCache, { | |||
| } from 'shared/cache/GenomeNexusCache'; | |||
| import _ from 'lodash'; | |||
| import { shouldShowMutationAssessor } from 'shared/lib/genomeNexusAnnotationSourcesUtils'; | |||
| import { selected } from 'pages/studyView/table/tables.module.scss'; | |||
There was a problem hiding this comment.
ideally shared components should not import from pages, but we probably broke that convention many times already, so not a big deal.
There was a problem hiding this comment.
Actrually this is an unused import. Removed this line.
Show Sift and Polyphen by different transcript
leexgh
force-pushed
the
fix-sift-polyphen
branch
from
77a500e
to
8146f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: cBioPortal/cbioportal#11150
Get Sift and Polyphen data from the selected/active transcript, instead of always getting from the first transcript.
Testing: add
Functional Impactcolumn in mutation table (link)Before:
After:
