Binning of custom data #10039
Binning of custom data #10039
Conversation
| @@ -0,0 +1,5093 @@ | |||
| { | |||
There was a problem hiding this comment.
Do we really need a test file this big? :)
There was a problem hiding this comment.
Reduced the size of the test file in dc81111
Jar is removed in dc81111 |
BasLee
force-pushed
the
custom_data_binning_endpoint
branch
2 times, most recently
from
61685ad
to
1625740
Compare
There was a problem hiding this comment.
@BasLee It looks good to me, thanks for performing refactoring work to make it organized. Most of my comments are about style or some code that might need clarification. I don't see anything wrong with it. Please feel free to reach out to me if there is anything not clear in my comments. Thanks!
service/src/main/java/org/cbioportal/service/util/CustomAttributeWithData.java
Show resolved
Hide resolved
service/src/main/java/org/cbioportal/service/util/CustomDataSession.java
Show resolved
Hide resolved
web/src/main/java/org/cbioportal/web/util/CustomDataDatatype.java
Outdated
Show resolved
Hide resolved
| uniqueSampleKeys.addAll(studyViewFilterApplier.getUniqkeyKeys(studyIds, sampleIds)); | ||
| uniquePatientKeys.addAll(studyViewFilterApplier.getUniqkeyKeys(studyIdsOfPatients, patientIds)); | ||
|
|
||
| if (clinicalAttributes != null && ! clinicalAttributes.isEmpty()) { |
There was a problem hiding this comment.
I prefer to leave no space between logical not and variable, maybe we can change to
| if (clinicalAttributes != null && ! clinicalAttributes.isEmpty()) { | |
| if (clinicalAttributes != null && !clinicalAttributes.isEmpty()) { |
There was a problem hiding this comment.
Thanks, @BasLee, it looks good to me! I will rebase your pr to the latest master. If everything looks good, I will merge it then.
dippindots
force-pushed
the
custom_data_binning_endpoint
branch
from
8ed06b6
to
01ba3dc
Compare
dippindots
force-pushed
the
custom_data_binning_endpoint
branch
from
01ba3dc
to
bae8b2b
Compare
|
SonarCloud Quality Gate failed. |
|
Thanks @dippindots ! |
Allow users to bin and filter their own custom (numerical and categorical) datasets using a new endpoint.
These changes will be used in a front end PR.
Changes
/custom-data-bin-counts/fetchtoStudyViewControllerto bin custom datasetsCustomDataServiceImpl, and share functionality at relevant placesCustomDataFilterApplierClinicalDataBinUtilto bin both clinical and custom data.Tests
StudyViewFilterApplierTestClinicalDataBinUtilTestapplicationContext-web-test.xmlin integration tests to fix missingCustomDataServiceImpl(and related) beans