Resolve KM plot censored event bug and add caching #11027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippindots
reviewed
Sep 27, 2024
| @@ -200,22 +201,19 @@ private List<ClinicalEvent> filterClinicalEvents(List<ClinicalEvent> patientEven | |||
|
|
|||
| // only fetch end timeline events for patients that have endClinicalEventsMeta and start timeline events | |||
| List<ClinicalEvent> queriedPatientEvents = new ArrayList<>(); | |||
| if (CollectionUtils.isNotEmpty(clinicalEventsMeta) && CollectionUtils.isNotEmpty(filteredStudyIds)) { | |||
There was a problem hiding this comment.
Is this line causing the issue?
| } | ||
|
|
||
| @Cacheable( | ||
| cacheResolver = "staticRepositoryCacheOneResolver", |
There was a problem hiding this comment.
Wondering why we need to use staticRepositoryCacheOneResolver at here, I think for the case with lots of permutations like this (study_ids with sample_ids) we should use generalRepositoryCacheResolver
No open issues yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues as part of #10375