Fix intersection with parens #11032
Merged
Fix intersection with parens #11032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisman
commented
Sep 29, 2024
| <!-- when you make selection in genomic binning chart, it will still send genomic data filter --> | ||
| <include refid="numericalGenomicDataFilter"/> | ||
| </otherwise> | ||
| ( |
There was a problem hiding this comment.
@fuzhaoyuan i think the problem was that we introduced a UNION ALL inside in order to handle the nulls and that needs to be scoped so as to avoid interfering with the INTERSECTION above it.
There was a problem hiding this comment.
probably needs to be applied also to generic assay
|
alisman
merged commit c82f34e
into
cBioPortal:demo-rfc80-poc-na-count-for-genomic-and-generic-assay
10 of 13 checks passed
alisman
deleted the
demo-rfc80-poc-na-count-for-genomic-and-generic-assay
branch
fuzhaoyuan
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Fix intersection with parens
fuzhaoyuan
pushed a commit
to fuzhaoyuan/cbioportal
that referenced
this pull request
Oct 2, 2024
* Fix intersection with parens
alisman
added a commit
that referenced
this pull request
Oct 2, 2024
* Add NA for genomic-data-bin-counts * Filtering with NA for genomic-data-bin-counts * Fix when subqueries return empty for NA counts * Refinement and comments * Address comments * Fix intersection with parens (#11032) * Fix intersection with parens * Demo rfc80 poc genomic data filter tests (#11036) * add genomic data filter tests testing for missing NAs * add NA genomic data filter tests --------- Co-authored-by: Zhaoyuan (Ryan) Fu <fuzhaoyuan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.