Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add categorical patient level filtering for generic-assay-data-counts #11155

Open
wants to merge 6 commits into
base: demo-rfc80-poc
Choose a base branch
from

Conversation

fuzhaoyuan
Copy link
Contributor

Fix #11115

@fuzhaoyuan fuzhaoyuan force-pushed the demo-rfc80-poc-generic-assay-patient-filtering branch from 15d1de8 to ba0ea1d Compare November 7, 2024 18:25
@fuzhaoyuan fuzhaoyuan changed the title Add patient level filtering for generic-assay-data-counts Add categorical patient level filtering for generic-assay-data-counts Nov 8, 2024
@fuzhaoyuan fuzhaoyuan force-pushed the demo-rfc80-poc-generic-assay-patient-filtering branch from 30e51ac to 3f7b42f Compare November 8, 2024 18:28
Copy link

sonarcloud bot commented Nov 8, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@fuzhaoyuan fuzhaoyuan force-pushed the demo-rfc80-poc-generic-assay-patient-filtering branch 4 times, most recently from 82336ac to b6c89af Compare November 14, 2024 21:54
@fuzhaoyuan fuzhaoyuan force-pushed the demo-rfc80-poc-generic-assay-patient-filtering branch from 0e6b4cb to c4ab845 Compare November 15, 2024 18:31
@fuzhaoyuan fuzhaoyuan marked this pull request as ready for review November 15, 2024 18:34
Copy link
Collaborator

@haynescd haynescd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@haynescd
Copy link
Collaborator

Only thing. Have you tried updating the Order By for

CREATE TABLE IF NOT EXISTS generic_assay_data_derived
(
    sample_unique_id String,
    patient_unique_id String,
    genetic_entity_id String,
    value String,
    generic_assay_type String,
    profile_stable_id String,
    entity_stable_id String,
    datatype String,
    patient_level NUMERIC,
    profile_type String
)
    ENGINE = MergeTree()
ORDER BY (profile_type, entity_stable_id, sample_unique_id);

To have patient_unique_id before sample_unique_id?

Copy link

sonarcloud bot commented Nov 18, 2024

@fuzhaoyuan
Copy link
Contributor Author

Only thing. Have you tried updating the Order By for

CREATE TABLE IF NOT EXISTS generic_assay_data_derived
(
    sample_unique_id String,
    patient_unique_id String,
    genetic_entity_id String,
    value String,
    generic_assay_type String,
    profile_stable_id String,
    entity_stable_id String,
    datatype String,
    patient_level NUMERIC,
    profile_type String
)
    ENGINE = MergeTree()
ORDER BY (profile_type, entity_stable_id, sample_unique_id);

To have patient_unique_id before sample_unique_id?

I didn't think of that. I'll add it in. Thanks for the catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants