added progress reporting to time-consuming compilation step, NOP functionality difference #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionality difference. 1. Emits a new progress message before starting sqlite compilation. 2. Clarifies existing download progress message: that a source release is being downloaded, and shows the download dir. Motivation: It wasn't obvious from the original message that installing sqlite3 with this plugin would take more than a few seconds. Compiling sqlite takes approx two minutes or so on my computer, so the new message is hopefully reassuring. After ----- ```bash $ asdf plugin remove sqlite $ asdf plugin add sqlite https://github.com/psranga/asdf-sqlite.git $ time asdf install sqlite latest downloading sqlite source code; url=https://www.sqlite.org/2024/sqlite-autoconf-3460100.tar.gz; destDir=/home/ubuntu/.asdf/downloads/sqlite/3.46.1 configure && compile && make install: this might take a minute; buildDir=/home/ubuntu/.asdf/downloads/sqlite/3.46.1; installDir=/home/ubuntu/.asdf/installs/sqlite/3.46.1 real 1m48.542s user 2m36.780s sys 0m5.426s $ which sqlite3 /home/ubuntu/.asdf/shims/sqlite3 ``` Before ------ ```bash $ asdf plugin add sqlite https://github.com/cLupus/asdf-sqlite.git $ time asdf install sqlite latest Downloading sqlite from https://www.sqlite.org/2024/sqlite-autoconf-3460100.tar.gz real 1m42.141s user 2m31.023s sys 0m5.254s $ which sqlite3 /home/ubuntu/.asdf/shims/sqlite3 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added progress reporting to time-consuming compilation step, NOP functionality difference.
Emits a new progress message before starting sqlite compilation.
Clarifies existing download progress message: that a source release
is being downloaded, and shows the download dir.
Motivation: It wasn't obvious from the original message that installing
sqlite3 with this plugin would take more than a few seconds. Compiling
sqlite takes approx two minutes or so on my computer, so the new message
is hopefully reassuring.
After
Before
$ asdf plugin add sqlite https://github.com/cLupus/asdf-sqlite.git $ time asdf install sqlite latest Downloading sqlite from https://www.sqlite.org/2024/sqlite-autoconf-3460100.tar.gz real 1m42.141s user 2m31.023s sys 0m5.254s $ which sqlite3 /home/ubuntu/.asdf/shims/sqlite3