Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade kubernetes 1.30+Upgrade packages+Upgrade go 1.23.3 #45

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Upgrade kubernetes 1.30+Upgrade packages+Upgrade go 1.23.3 #45

merged 1 commit into from
Dec 19, 2024

Conversation

zkonak
Copy link
Contributor

@zkonak zkonak commented Nov 18, 2024

Upgrade kubernetes packages to 1.30.6 + Upgrade packages + Upgrade go 1.23.3

evrardjp
evrardjp previously requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests? At list staticcheck (It would explain the ioutils -> os) or better - e2e tests.

@evrardjp-cagip
Copy link
Contributor

evrardjp-cagip commented Dec 19, 2024 •
edited
Loading

Did you update the toolchain before doing the update of go? Out of curiosity.

evrardjp-cagip
evrardjp-cagip requested changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@evrardjp-cagip evrardjp-cagip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jwt-go and ozzo-validation should also be bumped. Let's discuss this in a call.

evrardjp-cagip
evrardjp-cagip approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@evrardjp-cagip evrardjp-cagip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do only this at the moment, then do jwt-go and ozzo-validation in another PR.

@evrardjp-cagip evrardjp-cagip merged commit 75765fb into master Dec 19, 2024
6 checks passed
@evrardjp-cagip evrardjp-cagip deleted the dev_1.30 branch December 19, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evrardjp-cagip evrardjp-cagip evrardjp-cagip approved these changes

@evrardjp evrardjp evrardjp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zkonak @evrardjp-cagip @evrardjp @zelihacagip