Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fail if sha256sum does not present #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zkonak
Copy link
Contributor

@zkonak zkonak commented Dec 18, 2024

Without this, there is an incomprehensible error if sha256sum does not present.

This fixes by determining the reason for error sha256sum not present

@zkonak zkonak requested a review from evrardjp December 18, 2024 15:16
Copy link
Contributor

@evrardjp-cagip evrardjp-cagip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go releaser install script is fetched from upstream. Can you do this in the Makefile OR propose a fix upstream instead?

Without this, there is an incomprehensible error if sha256sum does not present.

This fixes by determining the reason for error sha256sum not present
@zkonak zkonak force-pushed the feat/sha256sum_fail branch from 565b084 to fa07618 Compare December 19, 2024 13:04
@@ -9,6 +9,7 @@ $(HACKDIR):
mkdir -p $(HACKDIR)

bootstrap-tools: $(HACKDIR)
if ! command -v sha256sum &> /dev/null; then echo "sha256sum could not be found"; exit 1; fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not valid in terms of Makefile. maybe check for @ or shell ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants