Remove go-ozzo/ozzo-validation package #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with that, we are no longer dependent on ozzo packages which is an external package and is no longer maintained without this, we are dependent on a external package that is very old
zkonak
changed the title
evrardjp-cagip
requested changes
Dec 23, 2024
| validation.Field(&ldapConfig.BindDN, validation.Required, validation.Length(2, 200)), | ||
| validation.Field(&ldapConfig.BindPassword, validation.Required, validation.Length(2, 200)), | ||
| ) | ||
| err = validateConfig(config) |
There was a problem hiding this comment.
validate config inside MakeConfig is very confusing.
Can't we simply use the MakeConfig as a constructor based on the config provided in the main, and validate all we need directly?
I am fine with splitting the function to make it clearer, so I am fine with validateLdapConfig. However, I believe that validation can be done immediately in a single step.
Also, we don't need to create validation functions, unless they are used multiple times and make it easier to read.
In all cases, don't forget to add tests...
evrardjp-cagip
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with that, we are no longer dependent on ozzo packages which is an external package and is no longer maintained
without this, we are dependent on a external package that is very old