Merge pull request #100 from yutak23/feature/fix-specialKeys-number

fix: NUMBER_VALUE cannot be converted to String on specialKeys
ca98am79 · Nov 14, 2024 · c8be1cf · c8be1cf
2 parents f2df74a + 25185cb
commit c8be1cf
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/lib/connect-dynamodb.js b/lib/connect-dynamodb.js
@@ -228,7 +228,7 @@ module.exports = function (connect) {
       this.specialKeys.forEach((key) => {
         if (typeof sess[key.name] !== "undefined") {
           const item = {};
-          item[key.type] = sess[key.name];
+          item[key.type] = key.type === 'N' ? JSON.stringify(sess[key.name]) : sess[key.name];
           params.Item[key.name] = item;
         } else {
           missingKeys.push(key.name);

diff --git a/test/test.js b/test/test.js
@@ -193,6 +193,44 @@ describe("DynamoDBStore", () => {
         );
       });
     });
+
+    it("should store data correctly with specialKeys option", async () => {
+      const store = new DynamoDBStore({
+        client: client,
+        table: tableName,
+        specialKeys: [
+          { name: 'number_field', type: 'N' }
+        ]
+      });
+      const randomNum = Math.floor(Math.random() * 1000) + 1;
+
+      await new Promise((resolve, reject) => {
+        store.set(
+          sessionId,
+          {
+            cookie: {
+              maxAge: 2000,
+            },
+            number_field: randomNum,
+          },
+          (err) => {
+            if (err) return reject(err);
+            resolve();
+          }
+        );
+      });
+
+      return new Promise((resolve, reject) => {
+        store.get(sessionId, function (err, res) {
+          if (err) return reject(err);
+
+          res.cookie.should.eql({ maxAge: 2000 });
+          res.number_field.should.eql(randomNum);
+
+          resolve();
+        });
+      });
+    });
   });
 
   describe("Getting", () => {