fix: Error when using EDITOR environment variable with arguments #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there!
First of all, thanks for this awesome little project :)
Description
This PR tries to fix the issue of using the
tt edit
command in combination with anEDITOR
environment variable that consists of a command with arguments.Issue
Example
I am using
EDITOR="code --wait"
as my environment variable for starting Visual Studio Code. Currently, this gives the following output:Reason
The whole string
"code --wait"
is passed toexec.Command
as the first argument. By documentation, only the command itself should be the first argument ofexec.Command
and any arguments of that command should follow as seperate arguments.Solution
If there are any spaces in the environment variable
EDITOR
, the command and it's argument are split into two seperate arguments forexec.Command
.In my testing both
and
worked fine with the proposed fix.