-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue where .env file is invalid #61
Conversation
This fixes cachethq#60 where the .env file is created without quotes
Most of these settings should never need to be double-quoted, but if it works then it's only going to prevent issues further down the line 👍 |
Ill be honest I didn't think all of them would need to be, but I guess it won't hurt though 😄 |
Interesting find.
Out of curiosity, which attribute were you using a space in? |
Usually it's |
Yeah it was just MAIL_NAME actually. I guess thats probably the only one that will need double quotes. I'm not sure if theres a better way of doing this in the entrypoint script? |
This is probably the simplest place. |
Shall I modify the PR to only change the |
It's possible that |
Well does it hurt leaving them all double quoted? |
Not that I know of. |
It hurts: see #151 |
This fixes #60 where the .env file is created without quotes