Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the /status endpoint #1945

Closed
wants to merge 8 commits into from
Closed

Add the /status endpoint #1945

wants to merge 8 commits into from

Conversation

adammbalogh
Copy link

@adammbalogh adammbalogh commented Jul 7, 2016

Closes #1936


The API endpoint is /statusfor getting all kinds of status messages. Right now it looks like this:

{
  "system_status": "danger",
  "system_message": "The service experiencing a major outage"
}

(It still needs unit tests.)

@GrahamCampbell
Copy link
Contributor

Please don't put things in the foundation namespace.

use CachetHQ\Cachet\Models\Component;
use CachetHQ\Cachet\Foundation\Queries\SystemStatusQuery;

class SystemStatusViewObject
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View object isn't really right. It's not used in the context of views exclusively?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not quite right. I'm thinking about how we should name this object.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need an object tbh. Just pass about an array.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That can work but how about a transformer object maybe?

@adammbalogh
Copy link
Author

adammbalogh commented Jul 7, 2016

@GrahamCampbell About foundation namespace. Sorry about that, I'm just learning the project with this PR. How we should structure my stuff, do you have an idea?

@GrahamCampbell
Copy link
Contributor

I'll have to get back to you later. At work right now.

@jbrooksuk
Copy link
Member

Replaced by #1968 :) much love to you for this @adammbalogh.

@jbrooksuk jbrooksuk closed this Jul 12, 2016
@GrahamCampbell GrahamCampbell added this to the V2.4.0 milestone Jul 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants