-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the /status endpoint #1945
Add the /status endpoint #1945
Conversation
Please don't put things in the foundation namespace. |
use CachetHQ\Cachet\Models\Component; | ||
use CachetHQ\Cachet\Foundation\Queries\SystemStatusQuery; | ||
|
||
class SystemStatusViewObject |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
View object isn't really right. It's not used in the context of views exclusively?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's not quite right. I'm thinking about how we should name this object.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't really need an object tbh. Just pass about an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can work but how about a transformer object maybe?
@GrahamCampbell About foundation namespace. Sorry about that, I'm just learning the project with this PR. How we should structure my stuff, do you have an idea? |
I'll have to get back to you later. At work right now. |
Replaced by #1968 :) much love to you for this @adammbalogh. |
Closes #1936
The API endpoint is
/status
for getting all kinds of status messages. Right now it looks like this:(It still needs unit tests.)