adding support for php including clean urls and wordpress permalinks #1
Conversation
| // ServeHTTP satisfies the middleware.Handler interface. | ||
| func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) { | ||
| servedFcgi := false | ||
| indexFile := "index.php" |
There was a problem hiding this comment.
Forgive me if i'm wrong, but aren't you making it so it ONLY allows php?
There was a problem hiding this comment.
Yes, this is specifically for PHP, which is my use case. This code needs to be generalized before merging in (specifically these variables should be configurable parameters in the CaddyFile). I've been discussing how best to do this with @mholt and he will be taking a look. Thanks for helping me clarify.
There was a problem hiding this comment.
Yep - we sat down yesterday and talked about this. I'll be working on it today to generalize it. Thanks for double-checking @norwack! We're both glad to have the feedback.
|
Matt Holt helped me generalize the fastcgi parameters and I've added the changeds into this pull request. |
adding support for php including clean urls and wordpress permalinks
|
Yesss - thank you, sir! Good detective work. This is a most excellent start. |
Cleanly fake-close listeners * WIP debugging listener deadlines * Fix listener deadlines
fix goroutine leak in healthcheckers
No description provided.