Fix position of "filter" in directives #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug of caddy-filter
mholt
requested changes
Jan 3, 2017
| @@ -410,6 +410,9 @@ var directives = []string{ | |||
| "gzip", | |||
| "header", | |||
| "errors", | |||
| "filter", // github.com/echocat/caddy-filter - Required at this position because if it is | |||
| // enabled it captures the response of following | |||
| // middlewares and modifies it. | |||
There was a problem hiding this comment.
We can probably lob off the explanation -- if we explained every directive, we'd have a bit of an unwieldy list. :) Keep the package path though. (Sorry, I know this absolute ordering isn't a great system, but it's the only correct way I can think of doing it!)
There was a problem hiding this comment.
No problem. I just think it could be a good idea to left a hint for this strange thing - that not someones reorders this and we trap in new trouble. :)
mholt
approved these changes
Jan 3, 2017
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to fix #2 Replacement doesn't happen - of caddy-fitler.