-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverseproxy: Add upstreams healthy metrics #4935
reverseproxy: Add upstreams healthy metrics #4935
Conversation
Looks cool! I'm not familiar with Prometheus so I'll let our in-house expert take a look if he has a chance 😃 I'll review the usage of the reverse proxy internals though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, thanks for the change! I'll leave it to Dave to do the final review if he has a chance.
@hairyhenderson I know you're busy so I won't require a review from you to merge this! Let me know if you want me to hold off so you can review, otherwise I will probably just merge it in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @david-szabo97, LGTM!
Great, thank you for the contribution @david-szabo97 ! |
I'm not a big fan of the hard-coded 10s delay between metric updates. |
Adds a new metric that tracks the health status of reverse proxy upstreams.
Metric:
caddy_reverse_proxy_upstreams_healthy
gauge
1
- the upstream is healthy0
- the upstream is unhealthyupstream
- Address of the upstreamExample Grafana panel:
Partially resolves #4140