-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connection policy: add local_ip
matcher
#6074
Conversation
21aad84
to
1694af7
Compare
Changing the PR to draft until I add tests and we have consensus on the discussion whether this is a good change |
I like where this is going. What if we just start with the local IP matcher and then see about adding the complexity of the matcher sets later if we feel it is needed based on real-world feedback? |
Done. |
local_ip
and not
matcherslocal_ip
matcher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, thank you!
I wonder if we should use this in the Caddyfile parser when crafting TLS connection policies -- instead of always using ServerName, which will be empty then the host is the IP address.
Not for this PR, but just thinking for future improvement.
Co-authored-by: Matt Holt <mholt@users.noreply.github.com>
This is for discussion, because I haven't thoroughly vetted the idea but curious if we can introduce more matchers to behave more like the HTTP handlers matchers.
It might resolve cases like #5771, depending on the use case.