Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: add Max-Age option to sticky cookie #6398

Merged
merged 3 commits into from
Jun 15, 2024
Merged

reverseproxy: add Max-Age option to sticky cookie #6398

merged 3 commits into from
Jun 15, 2024

Conversation

JasonYuan869
Copy link
Contributor

Addresses #6393

@CLAassistant
Copy link

CLAassistant commented Jun 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mholt
mholt approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you! We just need the imports reordered, I think, to comply with linter.

@JasonYuan869 JasonYuan869 force-pushed the cookie_max_age branch 3 times, most recently from e3f87bd to 88cb219 Compare June 14, 2024 18:36
@JasonYuan869 JasonYuan869 marked this pull request as ready for review June 14, 2024 18:36
@JasonYuan869 JasonYuan869 requested a review from mholt June 14, 2024 18:44
@francislavoie francislavoie added the feature ⚙️ New feature or request label Jun 14, 2024
@francislavoie francislavoie added this to the v2.8.5 milestone Jun 14, 2024
JasonYuan869 and others added 2 commits June 14, 2024 18:56
@JasonYuan869 @francislavoie
Update selectionpolicies.go
b084239 
Co-authored-by: Francis Lavoie <lavofr@gmail.com>
@JasonYuan869 @francislavoie
Update selectionpolicies.go
28792b1 
Co-authored-by: Francis Lavoie <lavofr@gmail.com>
@mholt mholt merged commit fab6375 into caddyserver:master Jun 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie left review comments

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
v2.8.5
Development

Successfully merging this pull request may close these issues.
4 participants
@JasonYuan869 @CLAassistant @mholt @francislavoie