Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: add health_upstream subdirective #6451

Merged
merged 10 commits into from
Jul 15, 2024
Merged

reverseproxy: add health_upstream subdirective #6451

merged 10 commits into from
Jul 15, 2024

Conversation

dylanschultzie
Copy link
Contributor

@dylanschultzie dylanschultzie commented Jul 9, 2024 •
edited
Loading

Currently in draft to update the documentation with the new subdirective.

Respective docs PR: caddyserver/website#406

Log when health_port and health_upstream is used:

Screenshot 2024-07-09 at 2 49 23 PM

@dylanschultzie dylanschultzie mentioned this pull request Jul 9, 2024
Merged
@dylanschultzie dylanschultzie marked this pull request as ready for review July 9, 2024 22:59
@francislavoie francislavoie added the feature ⚙️ New feature or request label Jul 11, 2024
@dylanschultzie
Update ignore health port comment
17397ba 
Signed-off-by: Dylan Schultz <9121234+dylanschultzie@users.noreply.github.com>
@dylanschultzie
Update Upstream json doc
111b5b8 
Signed-off-by: Dylan Schultz <9121234+dylanschultzie@users.noreply.github.com>
@dylanschultzie
Merge branch 'master' into schultzie/health_upstream
5c1eb94
dylanschultzie and others added 3 commits July 11, 2024 10:27
@dylanschultzie @francislavoie
Update modules/caddyhttp/reverseproxy/healthchecks.go
ad8a278 
Co-authored-by: Francis Lavoie <lavofr@gmail.com>
@dylanschultzie
Use error rather than log for health_port override
ecec709 
Signed-off-by: Dylan Schultz <9121234+dylanschultzie@users.noreply.github.com>
@dylanschultzie
Add comment about port being ignore if using upstream
ebb4626 
Signed-off-by: Dylan Schultz <9121234+dylanschultzie@users.noreply.github.com>
@mholt mholt enabled auto-merge (squash) July 15, 2024 16:46
@mholt
Copy link
Member

mholt commented Jul 15, 2024

Thanks for the contribution!

@mholt mholt merged commit b2492f8 into caddyserver:master Jul 15, 2024
23 checks passed
@dylanschultzie dylanschultzie deleted the schultzie/health_upstream branch July 15, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie left review comments

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
feature ⚙️ New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylanschultzie @mholt @francislavoie