Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflow): bump charts automatically when controller is released #119

Merged
merged 1 commit into from
Mar 15, 2023
Merged

chore(workflow): bump charts automatically when controller is released #119

merged 1 commit into from
Mar 15, 2023

Conversation

simenandre
Copy link
Contributor

This pull request adds a job in release-controller.yml which should automatically change appVersion in Charts.yml and image.tag in values.yaml (both located in charts/caddy-ingress-controller).

The idea behind this is as such: When developers make changes to the controller, we release a new version. However, we don't necessarily release new versions of our charts. This changes our flow to make it easier to roll out changes in charts easier. The flow typically will look like this if this is landed:

graph TD
    A[Create a new release/tag]
    B[Workflow triggered by tag event]

    A-->B

    C[Package controller with GoReleaser]
    D[Update Chart.yml and values.yml]
    E[Create pull request]

    B-->C
    B-->D
    D-->E
Loading

Note: We could even update version in Charts.yml with a patch version bump, triggering the workflow in release-chart.yml. Let me know if any of this would work out :)

@Embraser01
Copy link
Member

Note: We could even update version in Charts.yml with a patch version bump, triggering the workflow in release-chart.yml. Let me know if any of this would work out :)

Good idea!

I'm good with the concept of automatically bumping the chart when a new controller version is released. We will still have to bump it manually when changing the chart which may cause some weird behavior like bumping the version twice between a release. I don't know if we can conditionally bump the version only if needed 🤔

@simenandre
Copy link
Contributor Author

I'm good with the concept of automatically bumping the chart when a new controller version is released. We will still have to bump it manually when changing the chart which may cause some weird behavior like bumping the version twice between a release. I don't know if we can conditionally bump the version only if needed 🤔

We can use some magic like semantical commits to evaluate when to bump or not, not sure. Would it make sense to just have a pull request flow for now, and see how that all works out?

@Embraser01 Embraser01 merged commit 7c4aff2 into caddyserver:master Mar 15, 2023
@Embraser01
Copy link
Member

I'm good with the concept of automatically bumping the chart when a new controller version is released. We will still have to bump it manually when changing the chart which may cause some weird behavior like bumping the version twice between a release. I don't know if we can conditionally bump the version only if needed 🤔

We can use some magic like semantical commits to evaluate when to bump or not, not sure. Would it make sense to just have a pull request flow for now, and see how that all works out?

Let's go with that, and see alter if we can improve this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants