Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix skaffold config and update how to contribute docs #145

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Oct 7, 2023

Changes

  • Update doc on how to work locally
  • Remove needs from external tools for local development to simplify dev onboarding

NOTE: Do be merged after #142

@mavimo mavimo self-assigned this Oct 7, 2023
@mavimo mavimo marked this pull request as draft October 7, 2023 18:08
@mavimo mavimo changed the title Fix skaffold config chore: fix skaffold config and update how to contribute docs Oct 7, 2023
Base automatically changed from AaronDewes-update-caddy-2.7.3 to master October 16, 2023 09:20
@mavimo mavimo marked this pull request as ready for review October 23, 2023 06:52
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3250c15) 42.19% compared to head (6c862b8) 42.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          12       12           
  Lines         365      365           
=======================================
  Hits          154      154           
  Misses        210      210           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Dockerfile.dev Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@mavimo mavimo merged commit aaf3e54 into master Nov 5, 2023
4 checks passed
@mavimo mavimo deleted the fix-skaffold-config branch November 5, 2023 13:51
mavimo added a commit to Xinayder/caddy-ingress-controller that referenced this pull request Nov 7, 2023
…rver#145)

* chore: update skafold config and the doc on how to work locally

* chore: switch dev image to alpine
@mavimo mavimo mentioned this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants