fix: remove parameter that is not supported in the chart-release action #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #150 +/- ##
=======================================
Coverage 37.08% 37.08%
=======================================
Files 12 12
Lines 364 364
=======================================
Hits 135 135
Misses 228 228
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Embraser01
previously approved these changes
Oct 16, 2023
|
Checking this, the parameter does exists but isn't released yet. Should we just wait for a new release so that the this option is used or should we remove it and readd it later? (I think latest release should always be related to the Ingress controller and not to the helm chart) |
|
@Embraser01 maybe we can just refer to a new version instead of |
Good for me 👍 |
mavimo
force-pushed
the
fix-github-action-parameter
branch
from
90332bc
to
a87eba1
Compare
|
@Embraser01 updated as discussed. |
Embraser01
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
mark_as_latestparameter that is not supported from the chart-release action, see here