Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to go 1.21 and always use latest version #151

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Update to go 1.21 and always use latest version #151

merged 1 commit into from
Oct 16, 2023

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Oct 14, 2023

Changes

  • Update to go 1.21
  • Force CI to use the last minor version available (to keep consistency with what caddy is doing here)

@mavimo mavimo self-assigned this Oct 14, 2023
@mavimo mavimo changed the base branch from master to AaronDewes-update-caddy-2.7.3 October 14, 2023 10:41
@mavimo mavimo marked this pull request as draft October 14, 2023 10:41
@codecov
Copy link

codecov bot commented Oct 14, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (1e9f1d1) 32.42% compared to head (df3e861) 32.42%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   32.42%   32.42%           
=======================================
  Files          10       10           
  Lines         293      293           
=======================================
  Hits           95       95           
  Misses        197      197           
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from AaronDewes-update-caddy-2.7.3 to master October 16, 2023 09:21
@Embraser01 Embraser01 force-pushed the update-to-go-1.21-and-always-use-latest-version branch from 1a7f976 to df3e861 Compare October 16, 2023 10:02
@Embraser01 Embraser01 marked this pull request as ready for review October 16, 2023 11:10
Embraser01
Embraser01 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Embraser01 Embraser01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and validated ✅

@Embraser01 Embraser01 merged commit d7ffeb6 into master Oct 16, 2023
4 checks passed
@Embraser01 Embraser01 deleted the update-to-go-1.21-and-always-use-latest-version branch October 16, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Embraser01 Embraser01 Embraser01 approved these changes

Assignees

@mavimo mavimo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mavimo @Embraser01