-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update k8s.io packages and remove the errors package #152
Conversation
49d3085
to
31e43d6
Compare
31e43d6
to
0fb9b6b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 37.08% 37.08%
=======================================
Files 12 12
Lines 364 364
=======================================
Hits 135 135
Misses 228 228
Partials 1 1
☔ View full report in Codecov by Sentry. |
20e9374
to
7d67b6c
Compare
7d67b6c
to
3f7c531
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didn't had time to test it. May break support for older K8S version?
@Embraser01 it should not break anything. I'll double check with a cluster with the oldest kubernetes version I can create 😅 |
@Embraser01 tested on:
|
Changes
k8s.io
packagesfmt.Errorf
instad ofgithub.com/pkg/errors
to wrap errors