Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update k8s.io packages and remove the errors package #152

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Oct 14, 2023

Changes

  • Update k8s.io packages
  • Use fmt.Errorf instad of github.com/pkg/errors to wrap errors

@mavimo mavimo self-assigned this Oct 14, 2023
@mavimo mavimo marked this pull request as draft October 14, 2023 11:26
Base automatically changed from AaronDewes-update-caddy-2.7.3 to master October 16, 2023 09:21
@mavimo mavimo marked this pull request as ready for review October 16, 2023 15:28
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f2c316b) 37.08% compared to head (3f7c531) 37.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   37.08%   37.08%           
=======================================
  Files          12       12           
  Lines         364      364           
=======================================
  Hits          135      135           
  Misses        228      228           
  Partials        1        1           
Files Coverage Δ
pkg/store/configmap_parser.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavimo mavimo force-pushed the update-kubernetes-package branch 2 times, most recently from 20e9374 to 7d67b6c Compare October 21, 2023 09:55
Copy link
Member

@Embraser01 Embraser01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didn't had time to test it. May break support for older K8S version?

@mavimo
Copy link
Member Author

mavimo commented Oct 30, 2023

@Embraser01 it should not break anything. I'll double check with a cluster with the oldest kubernetes version I can create 😅

@mavimo
Copy link
Member Author

mavimo commented Nov 4, 2023

@Embraser01 tested on:

Provider Version Proxy protocol Result
AWS v1.25.15-eks-4f4795d Yes (v2)
AWS v1.25.15-eks-4f4795d No
Scaleway 1.26.9 Yes
Scaleway 1.26.9 Yes (v1)
Scaleway 1.26.9 Yes (v2)
Scaleway 1.26.9 No
Scaleway 1.27.6 Yes (v1)
Scaleway 1.27.6 Yes (v2)
Scaleway 1.27.6 No
Digitalocean 1.28.2-do.0 No
Digitalocean 1.28.2-do.0 Yes (v1)
Hetzner (k3s) v1.26.4+k3s1 No
Hetzner (k3s) v1.26.4+k3s1 Yes (v?)

@mavimo mavimo merged commit 78ef69e into master Nov 4, 2023
3 of 4 checks passed
@mavimo mavimo deleted the update-kubernetes-package branch November 4, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants