Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move internal function to private #154

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

mavimo
Copy link
Member

@mavimo mavimo commented Oct 15, 2023

Changes

  • Move function to private as already done in the ConfigMap

@mavimo mavimo self-assigned this Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (539dc67) 32.42% compared to head (37949ff) 32.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   32.42%   32.42%           
=======================================
  Files          10       10           
  Lines         293      293           
=======================================
  Hits           95       95           
  Misses        197      197           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mavimo mavimo changed the title chore: move internal function to provate chore: move internal function to private Oct 15, 2023
@Embraser01 Embraser01 merged commit 5e9d877 into master Oct 16, 2023
4 checks passed
@Embraser01 Embraser01 deleted the move-internal-function-to-private branch October 16, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants