-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): add service.yaml #253
base: main
Are you sure you want to change the base?
Conversation
@sanadhis thanks for your contribution! May I ask to include the new keys in the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #253 +/- ##
==========================================
+ Coverage 18.34% 21.89% +3.55%
==========================================
Files 30 30
Lines 1063 1087 +24
==========================================
+ Hits 195 238 +43
+ Misses 867 847 -20
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
Thanks for your feedback! |
@sanadhis Thanks! |
Hey, yes I am well aware, I was thinking to keep things simple. Sure I can add it back. I'll do some refactor also since we provide default value anyway. I am also squashing my commits |
1f7b108
to
7e90b6a
Compare
7e90b6a
to
e5cd36e
Compare
@mavimo can we merge this one please? Thanks! |
@sanadhis I'll try to run the validation and merge ASAP I'm planning to release a new version as soon as this is merged. |
What problem:
I need to install caddy to K8s, but I don't need external load balancer.
Why this is a solution:
By adding this
loadBalancer.enabled
value, which default to true, we can make the load balancer optional. This is also to ensure smart transition toservice.yaml
for already-existing user of this helm chart.