-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #141
Update documentation #141
Conversation
schmoelder
commented
Jul 27, 2023
•
edited
Loading
edited
- Add backlinks in documentation from parameters to model
- Consistent binding model order in documentation
- Consistent model/config tags in documentation
- Fix inline issue in documentation
- Update badges for README
- Add citing section to README
- Update copyright to 2023 (@sleweke how is that currently done?)
@sleweke Do you know why appveyor is still trying to build CADET? |
cf90fcc
to
364783e
Compare
I'm not opposed to having the "Citing" section in the README but I just wanted to comment that at some point @lieres and I had decided to leave the Github REAMDE as clean as possible and move all relevant information to the website where we already have a citing section. Background was that we didn't want to clutter information everywhere and instead have a single point of entry for CADET (i.e. cadet.github.io). For comparison, the CADET-Process Github page and entry on readthedocs are identical (which I also like). |
Makes sense to me, maybe we should just edit the citing section on the website. On the other hand, things may have changed now that we have the zenodo doi linked in the github readme. |
Having identical content will not be possible for CADET-Core and cadet.github.io, as the latter serves as central landing page for the whole CADET multiverse. Hence, it might be useful to copy some but not all information, and I think citing section is important. |
I agree, but that was also the reason why removed the citing section (311d626) from this page to focus on code-releated things and and instead refer to https://cadet.github.io I'm fine if we reinstate it here. Just wanted to mention it. |
README.rst
Outdated
@@ -31,6 +34,25 @@ Optionally, use `mamba <https://github.com/mamba-org/mamba>`_ which uses a faste | |||
|
|||
`Additional information <https://cadet.github.io/master/getting_started/installation>`_ and a `tutorial <https://cadet.github.io/master/getting_started/tutorials/breakthrough>`_ are available to guide you through the installation and the first steps of using CADET. | |||
|
|||
Citing | |||
------------ | |||
The development of CADET has been a remarkable collaborative effort, with multiple dedicated individuals contributing their expertise to create a powerful and versatile open-source software tool. Countless hours of hard work and innovation have been invested to provide the scientific community with a valuable resource for chromatography analysis and design. As an open-source project, CADET relies on the support and recognition from users and researchers to thrive. Therefore, we kindly request that any publications, research, or work leveraging the capabilities of CADET acknowledge its creators and their seminal contributions by citing a relevant subset of the following publications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please write every sentence on a single line
README.rst
Outdated
|
||
- **Püttmann, A.; Schnittert, S.; Naumann, U.; von Lieres, E.: Fast and accurate parameter sensitivities for the general rate model of column liquid chromatography**, Computers and Chemical Engineering 56,13 (2013), 46-57. `DOI: 10.1016/j.compchemeng.2013.04.021 <https://doi.org/10.1016/j.compchemeng.2013.04.021>`_ | ||
|
||
Additionally, we recommend citing the zenodo doi for the specific release that you used in your work to ensure reproducibility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarify usage of Zenodo DOI vs other publications
bf322c2
to
5b3187e
Compare
b08f3bd
to
4730d35
Compare
4730d35
to
a0c784b
Compare
This is almost ready to merge. However, documentation seems to be breaking currently. I suspect Also, @sleweke, updating the copyright I had to touch 358 files. To keep sanity, I used |
I can't reproduce the error locally, but based on the error we get here, I don't think it's
Google turned up this for
which suggests that the fault may lie in a missing/outdated installation of |
¯_(ツ)_/¯ I don't know why, but putting |
155fe95
to
964de52
Compare
I don't think there is another way.
As far as I know, we do not need the years in the copyright statement. For example, curl recently removed them: https://daniel.haxx.se/blog/2023/01/08/copyright-without-years/ |