Fix missing CSTR bulk solution export #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CSTR model now reports 1 primary coordinate element. To comply with the interface, it also returns a coordinate value. Because of the primary coordinate, the shape of the written bulk solution will be (numTimesteps, 1, numComponents). This is a breaking change compared to previous versions. In order to selectively remove the singleton dimension, the function hasPrimaryExtent() is added to the ISolutionExporter interface. This flag determines whether the unit operation model actually extents in the primary coordinate direction, that is, whether it is a true spatial element. If a unit operation model does not have primary extent, the singleton dimension will be removed. Fixes #149.
ronald-jaepel
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CSTR model now reports 1 primary coordinate element. To comply with the interface, it also returns a coordinate value.
Because of the primary coordinate, the shape of the written bulk solution will be
(numTimesteps, 1, numComponents). This is a breaking change compared to previous versions. In order to selectively remove the singleton dimension, the functionhasPrimaryExtent()is added to theISolutionExporterinterface. This flag determines whether the unit operation model actually extents in the primary coordinate direction, that is, whether it is a true spatial element. If a unit operation model does not have primary extent, the singleton dimension will be removed.Fixes #149.