Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exchange module for the MCT #257

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

AntoniaBerger
Copy link
Collaborator

@AntoniaBerger AntoniaBerger commented Jul 31, 2024

Fixes #252

Work structure:

  • Create a new exchange modul. #256
  • Add exchange as a part of the MCT modul
    • make exchange parameter parameter part of MCT
    • ubdate parameter handler for phaseTransitionModel
    • Test results
  • Outsourse Iteration and declaration for residual and Jacobian?

Copy link
Contributor

@jbreue16 jbreue16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a couple of minor remarks that need to be addressed before merging.

I thought about adding a dummy Exchange (similar to what we have for binding), but decided against it since there should always be some exchange in the MCT, as using that model doesnt make sense without.

Tests still work, so I'll approve this PR to be merged after minor revision.
It would still be interesting if the abstraction layer has any influence on the performance of the MCT. A benchmark would be nice, comparing the old and new implementation wrt computational performance.

src/libcadet/ConfigurationHelper.hpp Outdated Show resolved Hide resolved
src/libcadet/ExchangeModelFactory.cpp Outdated Show resolved Hide resolved
src/libcadet/model/ModelUtils.hpp Outdated Show resolved Hide resolved
src/libcadet/model/MultiChannelTransportModel.cpp Outdated Show resolved Hide resolved
src/libcadet/model/MultiChannelTransportModel.cpp Outdated Show resolved Hide resolved
test/ParticleHelper.cpp Outdated Show resolved Hide resolved
src/libcadet/CMakeLists.txt Outdated Show resolved Hide resolved
src/libcadet/ExchangeModelFactory.hpp Outdated Show resolved Hide resolved
src/libcadet/ExchangeModelFactory.hpp Outdated Show resolved Hide resolved
src/libcadet/ExchangeModelFactory.hpp Outdated Show resolved Hide resolved
src/libcadet/ExchangeModelFactory.hpp Outdated Show resolved Hide resolved
src/libcadet/model/MultiChannelTransportModel.cpp Outdated Show resolved Hide resolved
src/libcadet/model/binding/LinearBinding.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Awaiting Review
Development

Successfully merging this pull request may close these issues.

Add an exchange module for the MCT
2 participants