Add Affinity Energy Distribution isotherm and Rate Constant Distribution theory to the documentation #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Flynn, thanks for starting this. |
WFlynnZ
force-pushed
the
feature/AED_RCD
branch
from
2dc1442
to
f3575b1
Compare
jbreue16
force-pushed
the
feature/AED_RCD
branch
from
29da456
to
a67365c
Compare
jbreue16
changed the title
jbreue16
force-pushed
the
feature/AED_RCD
branch
from
a67365c
to
d1461d2
Compare
jbreue16
approved these changes
Nov 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add documentations for the Affinity Energy Distribution (AED) isotherm and Rate Constant Distribution (RCD) theory. Both equations are integral equations and need to be discretized before solving them numerically. However, the discretized equation can already be solved in CADET based on other previous isotherm and reaction implementations. Therefore, the task is to simply add documents.
Specially, if one is only interested in obtaining an AED from the experimental isotherm data, a specialized algorithm called Expectation Maximization (EM) method is available to solve the inverse problem. The EM method is an iterative method based on simple algebraic operations and is independent on other functionalities of CADET. For it to be part of the CADET family, we need a dedicated simple module that can be called by the user.
This is captured in another issue #314