adding method to allow choosing when to instantiate null params #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what do you think guys? (note: docs coming soon) |
| Instantiator<Object> objectInstantiator = new ObjectInstantiator(this, provider, parameterNameProvider); | ||
|
|
||
| if (!instantiateNullParameters()) { | ||
| objectInstantiator = new NullDecorator(objectInstantiator); |
There was a problem hiding this comment.
NullDecorator keeps nulls? If so, you shouldn't have the ! on the if.
There was a problem hiding this comment.
nevermind. But the name is confusing.
I'd use something like useNullForMissingParameters with false as default. And change the method to protected
There was a problem hiding this comment.
I agree with useNullForMissingParameters. Good point.
There was a problem hiding this comment.
I agree with you guys, done here 99ae0c0
|
all changes applied, I'll write some docs about it before 🚢 |
|
docs added here #663. Can I 🐑 it? |
| multiInstantiator = new MultiInstantiator(instantiatorList); | ||
| } | ||
|
|
||
| public boolean useNullForMissingParameters() { |
There was a problem hiding this comment.
why not protected, use only extended
|
:go-horse: |
Turini
added a commit
that referenced
this pull request
Jul 4, 2014
adding method to allow choosing when to instantiate null params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #532