Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only license is templated #167

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

caffeine-addictt
Copy link
Owner

Description

See commit message

Checklist

  • I have read and understood the Contributing Guide.
  • I have tested the code and it is working as expected.
  • I have incremented the version number with make bump version=vX.X.X according to SemVer.

Signed-off-by: AlexNg <contact@ngjx.org>
Signed-off-by: AlexNg <contact@ngjx.org>
This fixes the issue where /tmp/template-xxxx/template/waku[.ext] is
passed into the ignore rules, causing it to ignore everything and only a
LICENSE file is written. This patch just converts the path to the
relative path to the cloned dir in tmp. In other words the above turns
into template/waku[.ext].

Signed-off-by: AlexNg <contact@ngjx.org>
Signed-off-by: AlexNg <contact@ngjx.org>
@caffeine-addictt caffeine-addictt added the Type: Bug Something isn't working as expected. label Oct 16, 2024
@caffeine-addictt caffeine-addictt self-assigned this Oct 16, 2024
@github-actions github-actions bot added the Documentation An issue/change with the documentation. label Oct 16, 2024
@caffeine-addictt caffeine-addictt merged commit fb35c81 into main Oct 16, 2024
10 checks passed
@caffeine-addictt caffeine-addictt deleted the fix-only-license-templated branch October 16, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation An issue/change with the documentation. Type: Bug Something isn't working as expected.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant