Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experiment): Add a check before deletion (#1223) #11

Merged
merged 1 commit into from
Sep 16, 2020
Merged

feat(experiment): Add a check before deletion (#1223) #11

merged 1 commit into from
Sep 16, 2020

Conversation

whalecold
Copy link
Member

  • feat(experiment): Add a check before deletion

Signed-off-by: Ce Gao gaoce@caicloud.io

  • fix: Delete all trials

Signed-off-by: Ce Gao gaoce@caicloud.io

  • feat: Implement in v1beta1

Signed-off-by: Ce Gao gaoce@caicloud.io

@caicloud-bot
Copy link

@whalecold: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository.

@caicloud-bot caicloud-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Sep 16, 2020
@caicloud-bot
Copy link

Thanks for your pull request. Before we can look at your pull request, you'll need to finish a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/caicloud/engineering/blob/master/guidelines/cla.md to complete the CLA.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the caicloud/tools repository. I understand the commands that are listed here.

@caicloud-bot caicloud-bot added the caicloud-cla: no Indicates the PR's author has not signed the Caicloud CLA. label Sep 16, 2020
@whalecold
Copy link
Member Author

/release-note-none

@caicloud-bot caicloud-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 16, 2020
feat(experiment): Add a check before deletion (kubeflow#1223)
d0f3544 
* feat(experiment): Add a check before deletion

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* fix: Delete all trials

Signed-off-by: Ce Gao <gaoce@caicloud.io>

* feat: Implement in v1beta1

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@caicloud-bot caicloud-bot added caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. and removed caicloud-cla: no Indicates the PR's author has not signed the Caicloud CLA. labels Sep 16, 2020
@gaocegege
Copy link

/lgtm

@caicloud-bot caicloud-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
@whalecold
Copy link
Member Author

@gaocegege

cherrypick 上游 fix
ref: http://jira.caicloud.xyz/browse/CLV-3193

@caicloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@caicloud-bot caicloud-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2020
@caicloud-bot caicloud-bot merged commit 1ea2cd5 into caicloud:clv-1.7.x Sep 16, 2020
@whalecold whalecold deleted the CLV-3193 branch September 16, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gaocegege gaocegege

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. caicloud-cla: yes Indicates the PR's author has not signed the Caicloud CLA. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whalecold @caicloud-bot @gaocegege