Add basic packages for release #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdada
changed the title
kdada
changed the title
zoumo
suggested changes
Sep 12, 2017
pkg/kube/client.go
Outdated
| } | ||
| originalInfos := make(map[string]int) | ||
| for i, accessor := range originalAccessors { | ||
| originalInfos[accessor.GetName()] = i |
There was a problem hiding this comment.
这些 resource 中不同类型的资源重名了，会导致信息丢失
There was a problem hiding this comment.
需要有一个 keyFunc，从 GroupVersionKind + Name 生成 key
pkg/kube/client.go
Outdated
| for _, u := range updates { | ||
| origin, err := yaml.YAMLToJSON([]byte(u.origin)) | ||
| if err != nil { | ||
| return nil |
pkg/kube/client.go
Outdated
| } | ||
| target, err := yaml.YAMLToJSON([]byte(u.target)) | ||
| if err != nil { | ||
| return nil |
pkg/kube/client.go
Outdated
| } | ||
| obj, accessor, err := c.codec.AccessorForResource(u.origin) | ||
| if err != nil { | ||
| return nil |
pkg/kube/client.go
Outdated
| // TODO(kdada): Replace with merge patch when obj is TPR or CRD. | ||
| patch, err := strategicpatch.CreateTwoWayMergePatch(origin, target, obj) | ||
| if err != nil { | ||
| return nil |
| } | ||
| if !resource.Namespaced { | ||
| namespace = "" | ||
| } else if namespace == "" { |
There was a problem hiding this comment.
这样是不是就没办法拿到一个 client 可以查 AllNamespace 的资源了
There was a problem hiding this comment.
这个在这个函数注释里写明白了。可以允许使用 NamespaceAll，但是不能使用 Get 之类的方法。
pkg/kube/rest.go
Outdated
| client, ok := cp.clients[gvk] | ||
| if !ok { | ||
| conf := *cp.config | ||
| if gvk.Group == "" { |
There was a problem hiding this comment.
最好把 Group("") 给一个 const 值为 CoreGroup，易于理解
There was a problem hiding this comment.
v1 没有 Group， 和 CoreGroup 还是有区别的。k8s 也是这么判断的。
|
LGTM |
zoumo
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage: