Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] LSP integration #102

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bjorkstromm
Copy link
Member

@gep13 or @agc93 anyone of you want to continue with this? The newer OmniSharp builds now has much more stable LSP implementation.

@agc93
Copy link
Member

agc93 commented Mar 19, 2019

Yeah, I'll try and have a look. I was chatting to @madskristensen about this stuff this morning so I want to try and give it another crack with the more stable bits from O# and the more stable bits from the VS end as well.

@agc93
Copy link
Member

agc93 commented Mar 25, 2019

Currently blocked running into OmniSharp/csharp-language-server-protocol#132.

For my own reference, we still have a couple of big questions to sort out before we ship this:

  • Do we ship O# in-VSIX? Download on first use?
  • Do we try and locate/use the O# used from VS Code if its available?
  • How do we stop the server? Does StopAsync actually get called or is it usual VS trickery?

@bjorkstromm
Copy link
Member Author

@agc93 I’ve submitted a fix to OmniShatp here OmniSharp/omnisharp-roslyn#1503, once that’s merged, you can get the latest OmniSharp bits from the blob and try this out agan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants