Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add entries for Setup/Teardown in report #2005

Closed
patriksvensson opened this issue Jan 15, 2018 · 5 comments
Closed

Add entries for Setup/Teardown in report #2005

patriksvensson opened this issue Jan 15, 2018 · 5 comments
Labels
Feature
Milestone
v0.27.0

Comments

@patriksvensson
Copy link
Member

Would be nice to have timings for Setup/Teardown in the report (if they're implemented).

image
@devlead
Copy link
Member

devlead commented Jan 15, 2018

Agreed 👍

@wozzo
Copy link
Contributor

wozzo commented Jan 27, 2018

@devlead mind if I take a look at this one?

@devlead
Copy link
Member

devlead commented Jan 27, 2018

Sure go nuts

@wozzo
Copy link
Contributor

wozzo commented Jan 27, 2018 •
edited
Loading

@devlead I noticed in ExecuteTaskAsync that the following has been done. Is it ok to change to stopWatch.Restart() instead in the same PR. The StopWatch class reference source states it is an equivalent convenience method.

stopWatch.Reset();
stopWatch.Start();

@devlead
Copy link
Member

devlead commented Jan 27, 2018

@wozzo sure

@gep13 gep13 mentioned this issue Feb 22, 2018
Merged
@gep13 gep13 added this to the v0.27.0 milestone Feb 22, 2018
devlead added a commit that referenced this issue Mar 13, 2018
@devlead
Merge branch 'wozzo-GH-2005' into develop
c6b8a18 
* wozzo-GH-2005:
  (GH-2005) Add setup and teardown to report if run. * fixes #2005
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
v0.27.0
Development

No branches or pull requests
4 participants
@patriksvensson @gep13 @devlead @wozzo