Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect documentation for InnoSetup Alias #2220

Closed
SIkebe opened this issue Jul 25, 2018 · 1 comment
Closed

Incorrect documentation for InnoSetup Alias #2220

SIkebe opened this issue Jul 25, 2018 · 1 comment
Labels
Documentation
Milestone
v0.30.0

Comments

@SIkebe
Copy link
Contributor

SIkebe commented Jul 25, 2018

cake/src/Cake.Common/Tools/InnoSetup/InnoSetupAliases.cs

Lines 47 to 49 in ba349da

/// InnoSetup("./src/Cake.iss", new InnoSetupSettings {
/// OutputDir = outputDirectory
/// });

There is no property named OutputDir on InnoSetupSettings class.
That should be OutputDirectory.

InnoSetup("./src/Cake.iss", new InnoSetupSettings {
    OutputDirectory = outputDirectory
    });
SIkebe added a commit to SIkebe/cake that referenced this issue Jul 25, 2018
@SIkebe
(cake-buildGH-2220) Corrected documentation for InnoSetup alias
ee12a14
@SIkebe SIkebe mentioned this issue Jul 25, 2018
Closed
@gep13 gep13 added this to the v0.30.0 milestone Jul 25, 2018
gep13 pushed a commit that referenced this issue Jul 25, 2018
@SIkebe @gep13
(GH-2220) Corrected documentation for InnoSetup alias
daf53ae
gep13 added a commit that referenced this issue Jul 25, 2018
@gep13
Merge branch 'pr2221' into develop
bd6b23a 
* pr2221:
  (GH-2220) Corrected documentation for InnoSetup alias
@devlead
Copy link
Member

devlead commented Aug 14, 2018

Fixed by #2221

@devlead devlead closed this as completed Aug 14, 2018
devlead added a commit that referenced this issue Aug 22, 2018
@devlead
Merge branch 'release/0.30.0' into main
cab58db 
* release/0.30.0: (22 commits)
  (build) Updated version and release notes.
  (GH-2214) Use Environment.CommandLine directly and remove polyfill.
  (GH-2238) Add repository metadata to NuGet packages
  Added alias for checking if the current run is a dry run.
  Execute setup and teardown when dry running script.
  (GH-2233) Documented bootstrap argument
  (GH-2232) Document exclusive argument
  (GH-2234) Removed Mono from CakeOption
  Add XML comments for CakeTaskExtensions
  Fix CakeTaskExtensions accessibility
  (build) Change tool name & fix packaging
  (build) Added Cake.Tool package to parameters.cake
  Allow opting out from using working directory.
  (GH-2067) Cake .NET Core Tool package * Updates SDK * Addes Cake.Tool project * Fixes #2067 * Fixes #1644
  Support for DotCover configuration file added - fixes #1401
  Initialized all tool settings collection properties
  Failing tests for initialized tool settings collections
  (GH-2207) Update to NuGet 4.7.0
  (GH-2220) Corrected documentation for InnoSetup alias
  (doc) Minor modification
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v0.30.0
Development

No branches or pull requests
3 participants
@gep13 @devlead @SIkebe