Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide property to return parent directory on DirectoryPath #2763

Closed
pascalberger opened this issue May 10, 2020 · 10 comments · Fixed by #3349
Closed

Provide property to return parent directory on DirectoryPath #2763

pascalberger opened this issue May 10, 2020 · 10 comments · Fixed by #3349
Assignees
Milestone

Comments

@pascalberger
Copy link
Member

Currently getting the parent directory of a DirectoryPath requires some additional steps. Having a DirectoryPath.Parent property would be helpful.

@patriksvensson
Copy link
Member

Sounds good, but should be a method unless we construct this at the point that the directory is created.

@LagunaElectric
Copy link
Contributor

Hello! I'm new to this and would like to try tackling this issue :)

@LagunaElectric
Copy link
Contributor

Wow that was fast!

@augustoproiete
Copy link
Member

Awesome @LagunaElectric assigned it to you and looking forward to the PR!

@LagunaElectric
Copy link
Contributor

Mind if I ask for directions to DirectoryPath declaration?

@augustoproiete
Copy link
Member

@LagunaElectric
Copy link
Contributor

Thank you very much! I'm thinking of simply making a method there allowing one to do DirectroyPath.Parent as suggested above.

@augustoproiete
Copy link
Member

Sounds good. Probably something like:

public DirectoryPath GetParent()
{
    // ...
}

?

Don't forget to include unit tests in the PR! 😉

@LagunaElectric
Copy link
Contributor

Will do! Apparently my VS can't find the .NET Core SDKs. Rectifying that now.

@cake-build-bot
Copy link

🎉 This issue has been resolved in version v2.2.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants