Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1401: Support for DotCover configuration file added #2213

Conversation

AdaskoTheBeAsT
Copy link
Contributor

Support for DotCover configuration file added (now properly rebased).
Based on documentation for "cover" command
https://www.jetbrains.com/help/dotcover/dotCover__Console_Runner_Commands.html
"
It is possible to specify part of the parameters or all of them in the configuration file.
usage: dotCover cover [parameters]
"
configuration file name should be right after command

fixes #1401.

@AdaskoTheBeAsT AdaskoTheBeAsT force-pushed the feature/Support-for-dotCover-configuration-file branch from 9fa1d64 to caa7cc9 Compare July 19, 2018 16:50
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@AdaskoTheBeAsT
Copy link
Contributor Author

could you please give a tip what went wrong on Ubuntu check?

@bjorkstromm
Copy link
Member

@AdaskoTheBeAsT it timed out (AFAIK, not related to your changes). I kicked Ubuntu to run your PR again.

@devlead
Copy link
Member

devlead commented Jul 19, 2018

@AdaskoTheBeAsT it was a timeout, I've restarted the build.

@gep13 gep13 changed the title Support for DotCover configuration file added (rebased) GH1401: Support for DotCover configuration file added (rebased) Jul 25, 2018
@gep13 gep13 changed the title GH1401: Support for DotCover configuration file added (rebased) GH1401: Support for DotCover configuration file added Jul 25, 2018
@AdaskoTheBeAsT AdaskoTheBeAsT force-pushed the feature/Support-for-dotCover-configuration-file branch from caa7cc9 to 919d708 Compare July 26, 2018 17:04
@devlead devlead force-pushed the feature/Support-for-dotCover-configuration-file branch from 919d708 to d39001d Compare August 14, 2018 19:22
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit d39001d into cake-build:develop Aug 14, 2018
@devlead
Copy link
Member

devlead commented Aug 14, 2018

@AdaskoTheBeAsT your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for dotCover configuration file
3 participants