Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH2214: Use Environment.CommandLine directly and remove polyfill. #2244

Merged
merged 1 commit into from
Aug 21, 2018
Merged

GH2214: Use Environment.CommandLine directly and remove polyfill. #2244

merged 1 commit into from
Aug 21, 2018

Conversation

bjorkstromm
Copy link
Member

devlead
devlead approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@devlead devlead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@devlead devlead merged commit 4e6eb49 into cake-build:develop Aug 21, 2018
gep13
gep13 approved these changes Aug 21, 2018
View reviewed changes
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@devlead
Copy link
Member

devlead commented Aug 21, 2018

@mholo65 your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gep13 gep13 gep13 approved these changes

@devlead devlead devlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjorkstromm @devlead @gep13