GH2297 - Extended NUnit3Settings to support alternative app.config #2298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josiahpeters
commented
Sep 19, 2018
josiahpeters
commented
- Modified NUnit3Settings class to support new ConfigurationFile property that maps to --configfile=app.config for the nunit-console runner
- In the 3.8.0 release of the nunit-console runner, a new command line argument was added that supports loading the app.config file from an alternative path or file.
- Here is the new 3.8.0 feature: No way to specify app.config with console runner nunit/nunit-console#246
|
|
josiahpeters
force-pushed
the
josiahpeters-feature/GH-2297
branch
2 times, most recently
from
3817e2e
to
f2e6ae9
Compare
josiahpeters
changed the title
josiahpeters
force-pushed
the
josiahpeters-feature/GH-2297
branch
from
f2e6ae9
to
eab5df1
Compare
josiahpeters
force-pushed
the
josiahpeters-feature/GH-2297
branch
2 times, most recently
from
417b6c2
to
43e2793
Compare
patriksvensson
requested changes
Sep 27, 2018
| /// Gets or sets a value indicating the path to an alternative app.config file to load. | ||
| /// </summary> | ||
| /// <value>The location that NUnit should load an alternative app.config file from.</value> | ||
| public FilePath ConfigurationFile { get; set; } |
There was a problem hiding this comment.
I was a little too quick approving this PR. Could we make this argument match the NUnit argument name and rename it to ConfigFile?
- Modified NUnit3Settings class to support new ConfigFile property that maps to --configfile=app.config for the nunit-console runner - In the 3.8.0 release of the nunit-console runner, a new command line argument was added that supports loading the app.config file from an alternative path or file. - Here is the new 3.8.0 feature: nunit/nunit-console#246
josiahpeters
force-pushed
the
josiahpeters-feature/GH-2297
branch
from
43e2793
to
c94fe5d
Compare
|
@josiahpeters your changes have been merged, thanks for your contribution 👍 |
|
Relates to #2297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.