Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-184) Display info when add-in is pre-release & fix preprocessor directive #1266

Conversation

augustoproiete
Copy link
Member

  • Display information alert when the add-in is a pre-release version
  • Include the &prerelease parameter in the preprocessor directive example

image


Closes #184

@pascalberger
Copy link
Member

@augustoproiete Is there a reason why you have Allow Edits by maintainers disabled?

image

I tried to bring this branch up to date but got a permission error.

@augustoproiete
Copy link
Member Author

augustoproiete commented Nov 29, 2020

@pascalberger It's a missing feature of GitHub for me... I keep all my forks in a separate organization to remove the noise on my GitHub user account, and GitHub doesn't allow me to set "Allow Edits by maintainers" because of that unfortunately.

Anyway, I rebased the branch just now against latest master

@pascalberger pascalberger merged commit c43ab7b into cake-build:master Nov 29, 2020
@pascalberger
Copy link
Member

@augustoproiete your changes have been merged, thanks for your contribution 👍

@augustoproiete augustoproiete deleted the display-info-addin-pre-release branch November 29, 2020 10:34
@augustoproiete
Copy link
Member Author

augustoproiete commented Nov 29, 2020

@pascalberger It's a missing feature of GitHub for me... I keep all my forks in a separate organization to remove the noise on my GitHub user account, and GitHub doesn't allow me to set "Allow Edits by maintainers" because of that unfortunately.

@pascalberger I gave your user permission to write to my forks (website & cake) - I'm hoping this will resolve the "Allow Edits by maintainers" in future PRs once you've accepted the invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow addins to be marked as pre-release or beta
2 participants