Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Cake to 1.0.0 #98

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Bump Cake to 1.0.0 #98

merged 1 commit into from
Mar 29, 2021

Conversation

mhoellner
Copy link
Contributor

@mhoellner mhoellner commented Mar 5, 2021 •
edited by pascalberger
Loading

  • Update to Cake.Core 1.0.0

Fixes #101

@mhoellner
Copy link
Contributor Author

I suppose we need to wait for Cake.Recipe to support Cake 1.0.0 for a successful build (cake-contrib/Cake.Recipe#799).

pascalberger
pascalberger requested changes Mar 5, 2021
View reviewed changes
Copy link
Member

@pascalberger pascalberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we need to wait for Cake.Recipe to support Cake 1.0.0 for a successful build (cake-contrib/Cake.Recipe#799).

Thanks for the PR 👍 There's no need to build with Cake 1.0, we can just bump the Cake version in the project (and keep the version in the packages.config. Also the change in the AppVeyor.yml file should not be required, as the changed target would require Cake.Recipe 2.x.

@pascalberger
Copy link
Member

Sorry, AppVeyor image needs to be updated to Visual Studio 2019 to have .NET 5 available

@mhoellner
Copy link
Contributor Author

The build is still failing. Is this due to the slack integration?

@mhoellner
Copy link
Contributor Author

Hey @pascalberger, what can I do to get this merged? Is the CI build only failing due to the slack integration?

@pascalberger pascalberger merged commit 0445d6f into cake-contrib:develop Mar 29, 2021
@pascalberger
Copy link
Member

@mhoellner your changes have been merged, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalberger pascalberger pascalberger requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build against Cake 1.0
2 participants
@mhoellner @pascalberger